Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view): dev 모드 실행 정상화 #604

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix(view): dev 모드 실행 정상화 #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d758307
fix(view): vscode로 부터 view가 받는 메시지가 없는 dev 모드 실행을 위한 예외 처리
seungineer Aug 5, 2024
f9306fd
fix(vscode): vscode에서 view로 git config 정보를 보내는 부분 중 누락된 것 추가
seungineer Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/view/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ const App = () => {
useEffect(() => {
const handleMessage = (event: MessageEvent<RemoteGitHubInfo>) => {
const message = event.data;
setOwner(message.data.owner);
setRepo(message.data.repo);
if (message.data) {
setOwner(message.data.owner);
setRepo(message.data.repo);
}
};

window.addEventListener("message", handleMessage);
Expand Down
1 change: 1 addition & 0 deletions packages/vscode/src/webview-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ export default class WebviewLoader implements vscode.Disposable {
const gitLog = await getGitLog(this.gitPath, this.getCurrentWorkspacePath());
const gitConfig = await getGitConfig(this.gitPath, this.getCurrentWorkspacePath(), "origin");
const { owner, repo } = getRepo(gitConfig);
this.setGlobalOwnerAndRepo(owner, repo);
const engine = new AnalysisEngine({
isDebugMode: true,
gitLog,
Expand Down
Loading