Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs for control node #44

Merged
merged 1 commit into from
Nov 7, 2024
Merged

specs for control node #44

merged 1 commit into from
Nov 7, 2024

Conversation

mrbojangles3
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 7, 2024

🚀 Deployed on https://preview-44--hedgehog-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 15:42 Inactive
@qmonnet
Copy link
Member

qmonnet commented Nov 7, 2024

Just a question: Why is it relevant to give the specs that we use internally?

For the context, I'm not against adding specs that may help users to understand what hardware is known to work. My concern is tying the project and docs to Hedgehog as a company. Could we maybe rephrase it as “The VLAB is known to work on the following setup:” or “The project CI runs on:”, or “Project maintainers use the following setup:”?

@Frostman
Copy link
Member

Frostman commented Nov 7, 2024

@qmonnet the main goal is to have an easily referenceable section in docs to share with prospects as our tested recommendation.

@Frostman Frostman merged commit 302cb6a into master Nov 7, 2024
2 checks passed
@Frostman Frostman deleted the control_server_specs branch November 7, 2024 19:58
@qmonnet
Copy link
Member

qmonnet commented Nov 7, 2024

@Frostman Got it, but presented as Hedgehog 's (the company) setup, it doesn't give a vendor-neutral look to the project. Looking ahead, if we intend to set up some open-source governance model for the Fabric in the future, then there will be no reason that one vendor gets to list their setup in the project's docs, and not competition.

It's probably early to care too much about that, given at the moment it's necessary to register with Hedgehog to get the artefacts and run the Fabric anyway, but I think it's still something worth considering 🙂

@Frostman
Copy link
Member

Frostman commented Nov 7, 2024

@Frostman Got it, but presented as Hedgehog 's (the company) setup, it doesn't give a vendor-neutral look to the project. Looking ahead, if we intend to set up some open-source governance model for the Fabric in the future, then there will be no reason that one vendor gets to list their setup in the project's docs, and not competition.

It's probably early to care too much about that, given at the moment it's necessary to register with Hedgehog to get the artefacts and run the Fabric anyway, but I think it's still something worth considering 🙂

100% agree with you, at some point we will need to do a cleanup and separate company and project. Some of the examples would be docs under company domain, company name in the API namespace, Broadcom sonic dependency, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants