ci: Remove optional success for beta/nightly in dev.yml #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: It's expected that the required “summary” step does not complete, as this PR removes it. |
|
Thanks for the review! I'll fix the conflict soon. |
Using "continue-on-error: true" on various steps of dev.yml's jobs may hide build or test failures, as the job unconditionally returns true for these steps. Let's remove these attributes. If we want to allow these jobs to fail, we should simply avoid to mark them as required. This means adjusting the repository settings (compared to what we have currently) to not require the final "summary" step to succeed, but individual jobs, based on their job matrix value. Let's add job names to make it easier. Signed-off-by: Quentin Monnet <[email protected]>
We plan to adjust the way we mark workflows as required, and we will no longer require the summary steps for that. Let's remove them to save some CI cycles and shorten the list of status checks. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/ci-no-optional
branch
from
764641d to
7e7b3ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit logs for details.
Reboot of #94