-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design dataplane internals #141
Draft
daniel-noland
wants to merge
23
commits into
main
Choose a base branch
from
dataplane-internals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-noland
force-pushed
the
dataplane-internals
branch
3 times, most recently
from
December 6, 2024 03:43
1681628
to
c872d28
Compare
dpdk-sys 1. no longer provides nightly builds for sterile 2. made some adjustments to the wrte wrapper which required some minor renaming. 3. changed the name of the docker images This PR accounts for this
The javascript had gotten a little messy (frankly it still is), but it is far less chaotic now. Significant chunks of commented code have been removed.
The svg elements are being embedded with directly set width and height values. This overrides the CSS style they should be getting, so just move the assigned setting to style attributes.
No need to carry around .js files for mermaid.
This was used in another project and somehow made it in to this one. Remove.
Expand and re-organize docs to add in design work by the whole team.
Drawing up designs for the internals of the dataplane
daniel-noland
force-pushed
the
dataplane-internals
branch
from
December 6, 2024 18:44
c872d28
to
87fe89b
Compare
daniel-noland
force-pushed
the
dataplane-internals
branch
from
December 31, 2024 21:13
674810d
to
9e20873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawing up designs for the internals of the dataplane