Added users backend and fetched them in the dropdown #38
Conversation
girijaasoni
changed the title
|
Hey @girijaasoni, I created a PR to better test our frontend code in #42 |
Ron-Lavi
force-pushed
the
users-dropdown
branch
from
639b786 to
8fdd3ba
Compare
|
sorry, wrong push 🤣 but now it's rebased |
There was a problem hiding this comment.
Nice work @girijaasoni !
one concern is that we save the Article.creator as a string nor as a reference to the User model.
| {users.map((user) => ( | ||
| <DropdownItem key="group 1 action" component="button"> |
There was a problem hiding this comment.
can you use the user.id as a key?
currently there's an error:
Warning: Each child in a list should have a unique "key" prop.
| const handleChange = (value, key) => { | ||
| setData({ | ||
| ...data, | ||
| [key]: value | ||
| }); | ||
| }; | ||
| const onToggle = (isDropdownOpen) => { |
There was a problem hiding this comment.
as a convention, in Foreman we use 'handleToggle' instead of 'onToggle'
| </Button>{' '} | ||
| <PfButton | ||
| variant="link" | ||
| icon={<PlusCircleIcon />} |
| @@ -1,4 +1,5 @@ | |||
| Rails.application.routes.draw do | |||
| resources :users | |||
There was a problem hiding this comment.
can you move it below the root route?
| const onSelect = (event) => { | ||
| const value = event.target.innerHTML; | ||
| setSelectedUser(value); |
There was a problem hiding this comment.
instead of passing the string value of the user name,
can you pass the ID of the user? and also link in the database the Article.creator to User?
| const onSelect = (event) => { | ||
| const value = event.target.innerHTML; | ||
| setSelectedUser(value); |
There was a problem hiding this comment.
instead of passing the string value of the user name,
can you pass the ID of the user? and also link in the database the Article.creator to User?
girijaasoni
force-pushed
the
users-dropdown
branch
from
6c05375 to
a01bcd7
Compare
No description provided.