Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tile-frames for better frame browsing. #635

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

manthey
Copy link
Member

@manthey manthey commented Aug 12, 2021

This requires a version of GeoJS newer than v1.2.0 to have any effect.

This requires a version of GeoJS newer than v1.2.0 to have any effect.
@manthey manthey merged commit 5e7246a into master Aug 12, 2021
@manthey manthey deleted the tile-frames-client branch August 12, 2021 21:00
@manthey
Copy link
Member Author

manthey commented Aug 13, 2021

As an example of the difference, this uses the exact same 1000-frame source file. Before, we switched frames only when loaded:

Before1.mp4

After this update, we switch to the preview image immediately and then load the frames. You can see jpeg artifacts in the preview frames; these vanish as the actual tiles are loaded when the scroll pauses.

After1.mp4

@aashish24
Copy link

this is very nice. hard to read the code with many codecov warnings (not sure why that is happening). what is a tile frame?

@manthey
Copy link
Member Author

manthey commented Aug 13, 2021

I don't know why codecov is commenting PRs, since it is set to comment: false.

Many tile sources have multiple "frames" -- different bands on geospatial data, different z slices on histology images, time series, XY pan series, multiple channels, etc. large_image aggregates all of this into a concept of "frames" so that there is a 0-based index of these separate images. It requires that all of the images be the same resolution and have the same tile size and a similar tile structure (e.g., all frames are expected to have the same maximum depth of pyramidally arranged tiles, but not necessarily have the same levels of the pyramid filled out).

The synthetic image shown above simulates a moderate sized image with 1000 z slices -- I have some histology examples, but they are not necessarily public or, in some cases, particularly clear, so the synthetic image makes a more obvious demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants