Support reading OME Tiff files from sub-ifds. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgutman This will work on any OME Tiff that uses subifds assuming that the subifds are ordered largest to smallest and are every power of two below the main image (e.g., no skipped levels). This matches the samples I've seen. Let me know if any of the files you have are still super slow. |
manthey
force-pushed
the
subifd-pyramids
branch
from
c8b84c1
to
7eeaedf
Compare
I anticipate generalizing this to all tiff files that are so constructed eventually.
This especially speeds up scanning OME Tiff files that we can't ultimately read and have a lot of images.
manthey
force-pushed
the
subifd-pyramids
branch
from
7eeaedf
to
3e24804
Compare
|
I'm merging this into master as I have reports that it is working. Any issues found can be new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I anticipate generalizing this to all tiff files that are so constructed eventually.
We should add an explicit test case for this.