Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around an issue with Girder's settings' cache. #422

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Work around an issue with Girder's settings' cache. #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
## Unreleased

### Features
- Added a GET large_image/sources endpoint to list versions of all installed sources
- Added a GET large_image/sources endpoint to list versions of all installed sources (#421)

### Bug Fixes
- Fixed an issue where changing the annotation history setting when Girder's settings' cache was enable wouldn't take effect until after a restart (#422)

## Version 1.0.2

Expand Down
6 changes: 2 additions & 4 deletions girder_annotation/girder_large_image_annotation/models/annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,10 +502,8 @@ def _copyAnnotationsFromOtherItem(self, srcItemId, destItem):

def _onSettingChange(self, event):
settingDoc = event.info
if settingDoc['key'] in (
constants.PluginSettings.LARGE_IMAGE_ANNOTATION_HISTORY, ):
self._historyEnabled = Setting().get(
constants.PluginSettings.LARGE_IMAGE_ANNOTATION_HISTORY)
if settingDoc['key'] == constants.PluginSettings.LARGE_IMAGE_ANNOTATION_HISTORY:
self._historyEnabled = settingDoc['value']

def _loadAndMigrateAnnotation(self, id, *args, **kwargs):
"""
Expand Down