Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typos #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf4f736
Fix README typo
richardonrails Aug 9, 2020
d359c03
Fix typo `team_domian` -> `team_domain`
richardonrails Aug 21, 2020
fc06a18
Fix typo in client.rb
richardonrails Aug 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ Options for `scope`, `team`, `team_domain`, and `redirect_uri` can also be given
The `team_domain` query parameter will be inserted into the authorization GET request
as a subdomain `https://team-domain.slack.com/oauth/authorize`.

**NOTE:** Allowing `redirect_uri`, `scope`, or `team_domian` to be passed to Slack from your application's public interface (`https://myapp.com/auth/slack?scope=...`) is a potential security risk. As of omniauth-slack version 2.5.0, the default is to NOT allow `scope`, `redirect_uri`, or `team_domain` pass-through options at runtime, *unless* they are listed in the `:pass_through_params` option. The `team` param is allowed to pass through as a default.
**NOTE:** Allowing `redirect_uri`, `scope`, or `team_domain` to be passed to Slack from your application's public interface (`https://myapp.com/auth/slack?scope=...`) is a potential security risk. As of omniauth-slack version 2.5.0, the default is to NOT allow `scope`, `redirect_uri`, or `team_domain` pass-through options at runtime, *unless* they are listed in the `:pass_through_params` option. The `team` param is allowed to pass through as a default.

To block all pass-through options.

Expand Down Expand Up @@ -383,7 +383,7 @@ To extract data from the API response, call `parsed` on the response object.

Each Successful OmniAuth authorization places an
[AuthHash](https://github.com/omniauth/omniauth/wiki/Auth-Hash-Schema) object in the environment `env['omniauth.auth']`.
The AuthHash is just an enhanced hash object containing data from the[OAuth2](https://github.com/oauth-xx/oauth2)
The AuthHash is just an enhanced hash object containing data from the [OAuth2](https://github.com/oauth-xx/oauth2)
response received from the get-token API call made during the OmniAuth callback phase.
See OmniAuth's documentation for the AuthHash schema definition.

Expand Down
4 changes: 2 additions & 2 deletions lib/omniauth-slack/oauth2/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Client < ::OAuth2::Client
# @access_token.client.history = @auth_hash.extra.raw_info
#
# TODO: The above seems a little messy. Maybe use a proc
# to rediredct Client request history to wherever.
# to redirect Client request history to wherever.
# Or maybe don't offer any history storage at all.
#
HISTORY_DEFAULT=nil
Expand Down Expand Up @@ -92,4 +92,4 @@ def site(*args)
end
end
end
end
end