Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups, Refactors and a Datagen #106

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Minecraftschurli
Copy link

No description provided.

@gigaherz
Copy link
Owner

Uhhh... could you give an explanation of what you changed and why?
You made a lot of changes ;P

@Minecraftschurli
Copy link
Author

  1. I moved the book parsing into another class and those methods static
  2. I moved the document level elements and the inline elements to a map of factories like the custom elements
  3. I moved the default elements to the map of elements
  4. I added custom element post processors to be able to modify existing elements based on a custom attribute
  5. I moved the logger to slf4j
  6. I moved to the usage of try with resources
  7. I made it invalidate the include cache on reload
  8. I made a base interface for all elements including the ChapterData and such
  9. I expanded the parsing context to accommodate the new way of parsing
  10. I added the Color record to handle colors (can now also handle hsl)
  11. I added the Length record to handle lengths (width, height, ...) with units (px, %, ...)
  12. I converted the Size and Point classes to records (and renamed the Point classes to make it more clear what they are)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants