Add http basic auth based on env vars #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbovo this is good. I am thinking about how to make it optional. I mean if we don't inject the env vars we are still requiring an empty auth |
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Aug 22, 2017
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Aug 22, 2017
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Aug 22, 2017
|
@gianarb I've added a flag to enable (default disabled) authentication, with default user/pass (orbiter/orbiter) just in case. I'm using kelseyhightower/envconfig here to read custom configuration from env, seems a good lib. As improvement in I think configuration like this should be placed in global conf and propagated, instead of using repeated code. I will open another proposal/pr for this last point. |
|
I like the mapping idea. I dont think we need library to read some envvar. I think the os package is enough |
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Oct 1, 2017
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Oct 1, 2017
mbovo
pushed a commit
to mbovo/orbiter
that referenced
this pull request
Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.