refactor: Collections.sort could be replaced with List.sort

ghusta · Jan 2, 2024 · 4b0ceb3 · 4b0ceb3
1 parent 6518ba7
commit 4b0ceb3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/app/src/main/java/fr/husta/android/dockersearch/MainActivity.java b/app/src/main/java/fr/husta/android/dockersearch/MainActivity.java
@@ -27,7 +27,6 @@
 import com.google.android.material.dialog.MaterialAlertDialogBuilder;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Objects;
 
 import androidx.appcompat.app.AlertDialog;
@@ -276,7 +275,7 @@ public boolean onQueryTextSubmit(String query)
                 .doOnSubscribe(data -> progressBar.show())
                 .subscribe(data -> {
                             Log.d(TAG, "searchImagesAsync.onResponse: returned " + data.getResults().size() + " out of " + data.getNumResults());
-                            Collections.sort(data.getResults(), new DefaultImageSearchComparator());
+                            data.getResults().sort(new DefaultImageSearchComparator());
 
                             dockerImageExpandableListAdapter.notifyDataSetInvalidated(); // necessaire ?
                             // Collapse all

diff --git a/.../husta/android/dockersearch/docker/model/comparator/DefaultImageSearchComparatorTest.java b/.../husta/android/dockersearch/docker/model/comparator/DefaultImageSearchComparatorTest.java
@@ -3,13 +3,11 @@
 import org.junit.Test;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 
 import fr.husta.android.dockersearch.docker.model.ImageSearchResult;
 
 import static com.google.common.truth.Truth.assertThat;
-import static com.google.common.truth.Truth.assertWithMessage;
 
 public class DefaultImageSearchComparatorTest
 {
@@ -35,7 +33,7 @@ public void compare() throws Exception
         ImageSearchResult elt5 = new ImageSearchResult("elt5", "elt5", false, 2);
         list.add(elt5);
 
-        Collections.sort(list, comparator);
+        list.sort(comparator);
         assertThat(list).isNotEmpty();
         // #1 => elt3
         assertThat(list.get(0)).isSameInstanceAs(elt3);