Adding linenoise.cpp to llama-run #11252
Conversation
|
Linked issue: |
ericcurtin
force-pushed
the
linenoise.cpp
branch
8 times, most recently
from
fdaa9ba to
bd3e9ae
Compare
ericcurtin
force-pushed
the
linenoise.cpp
branch
2 times, most recently
from
14dc5f3 to
29d40de
Compare
|
This does not work on Windows? I guess inside of a container it would work. |
I couldn't find any library like linenoise that had Windows support. Plenty have macOS/Linux support. But yeah if using a container or WSL2, etc. we'd be fine. I didn't kill Windows native support here, but you don't get the cool features like being able to cycle through prompt history with up and down arrows. |
ericcurtin
force-pushed
the
linenoise.cpp
branch
from
29d40de to
47487ae
Compare
| * * Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. |
There was a problem hiding this comment.
Note that this will require adding a notice in the releases.
There was a problem hiding this comment.
Where can I copy that in? I think the license is compatible once we include these copyrights
There was a problem hiding this comment.
Not sure how this is usually handled, I guess we could add a file with all 3rd party copyright notices and copy it to the release packages.
There was a problem hiding this comment.
We have the same issue with CURL if we start distributing it for Windows FWIW, from curl license: "Permission to use, copy, modify, and distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies."
@ggerganov you were speaking about shipping curl on Windows recently.
There was a problem hiding this comment.
I also don't know what is the common way to handle this. Probably look for how other projects do it.
Btw, each llama.cpp release already includes a copy of the full source code in this repo so I think all licenses are technically already included in the release packages? Again, we can make this more explicit if necessary - feel free to improve.
There was a problem hiding this comment.
I'm ok with that technique, there's no standard technique. Everybody does it a little different.
ericcurtin
force-pushed
the
linenoise.cpp
branch
2 times, most recently
from
27812c8 to
6360829
Compare
|
Most of the time windows will be using a container so this should not be an issue. |
ericcurtin
force-pushed
the
linenoise.cpp
branch
from
6360829 to
be525f2
Compare
This is a fork of linenoise that is C++17 compatible. I intend on adding it to llama-run so we can do things like traverse prompt history via the up and down arrows: https://github.com/ericcurtin/linenoise.cpp Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
linenoise.cpp
branch
from
be525f2 to
4127d6a
Compare
We get prompt history etc. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
linenoise.cpp
branch
from
4127d6a to
1aa42d3
Compare
This is a fork of linenoise that is C++17 compatible. I intend on adding it to llama-run so we can do things like traverse prompt history via the up and down arrows:
https://github.com/ericcurtin/linenoise.cpp