ggml : fix undefined reference to std::filesystem(#10978) #10979
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
ggml/src/CMakeLists.txt
Outdated
| @@ -225,7 +225,7 @@ add_library(ggml | |||
| target_link_libraries(ggml PUBLIC ggml-base) | |||
|
|
|||
| if (CMAKE_SYSTEM_NAME MATCHES "Linux") | |||
| target_link_libraries(ggml PRIVATE dl) | |||
| target_link_libraries(ggml PRIVATE dl stdc++fs) | |||
There was a problem hiding this comment.
We'd need to check for GCC vs Clang or more specifically libstdc++ vs libc++.
There was a problem hiding this comment.
Check if CMAKE_CXX-COMPILER_ID is GNU
add link library stdc++fs for ggml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add link library stdc++fs for ggml.