server : add support for "encoding_format": "base64" to the */embeddings endpoints #10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Dec 24, 2024
| assert len(floats) > 0 | ||
| assert all(isinstance(x, float) for x in floats) | ||
| except Exception as e: | ||
| pytest.fail(f"Invalid base64 format: {str(e)}") |
There was a problem hiding this comment.
It's a bad practice to use try..catch inside a test, because if one of the assert fails, it won't let you know it happens at exactly which line of code.
There was a problem hiding this comment.
@ngxson, thanks for the hint. my bad, I forgot to remove it.
ngxson
approved these changes
Dec 24, 2024
ngxson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add base64 encoding format support for embeddings endpoints
Overview
This PR implements support for base64 format in embedding responses, aligning with OpenAI's API functionality and improving payload efficiency.
Changes
encoding_formatparameter support to embedding endpointsRelated Issue
Closes #10887