-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulkan: build fixes for 32b #10927
vulkan: build fixes for 32b #10927
Conversation
Should fix ggerganov#10923
The Might want to fix these too. |
Second commit ought to fix the uninitialized variables, though I couldn't reproduce the warnings/errors locally. |
Thanks. Also, I remember you discussed recently the segfault upon program exit, but not sure which discussion was this. Do you have any ideas how this would be resolved? It's preventing the |
For what it's worth here's the thread discussing the segfault. It seems to be intermittent so if you restart the CI again you might be able to avoid it for now. |
It's no longer segfault-ing after the restart. However, the CI appears to have revealed an issue when computing embeddings: |
This command is randomly segfault-ing upon exit: ./bin/llama-embedding --model ../models-mnt/rerank-tiny/ggml-model-f16.gguf -p "what is panda?</s></s>hi\nwhat is panda?</s></s>it's a bear\nwhat is panda?</s></s>The giant panda (Ailuropoda melanoleuca), sometimes called a panda bear or simply panda, is a bear species endemic to China." -ngl 99 -c 0 --pooling rank --embd-normalize -1 --verbose-prompt I tried to get a stacktrace, but it's optimized out even in Debug for some reason:
|
Based on the thread name it's the same as #10528. The stack is entirely in a driver thread, so I wouldn't expect to be able to get a useful stack trace. |
Should fix #10923