-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama : refactor src/llama.cpp
#10902
Draft
ggerganov
wants to merge
19
commits into
master
Choose a base branch
from
gg/llama-refactor-0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+18,774
−18,340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think |
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
8 times, most recently
from
December 22, 2024 16:24
524886b
to
7ab08d5
Compare
github-actions
bot
added
examples
devops
improvements to build systems and github actions
labels
Dec 22, 2024
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
2 times, most recently
from
December 22, 2024 20:30
be8f568
to
dcbfda1
Compare
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 22, 2024 21:47
e1ac353
to
af43dc7
Compare
ggml-ci
ggml-ci
ggml-ci
ggml-ci
ggml-ci
ggml-ci
ggml-ci
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 09:52
af43dc7
to
de014bc
Compare
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 13:16
4f987ce
to
d8ee2ba
Compare
ggml-ci
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 13:46
d8ee2ba
to
b0d6b66
Compare
ggml-ci
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 15:42
4816008
to
a7df071
Compare
ggml-ci
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 16:43
26b5cfd
to
7035c79
Compare
ggerganov
force-pushed
the
gg/llama-refactor-0
branch
from
December 23, 2024 17:22
ba48e37
to
0ccae21
Compare
ggml-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to split the
src/llama.cpp
into a few separate modules. Very work-in-progress, mainly opening this PR for people to keep track and suggest improvements as we move along. This part does not involve functional changes, just code reorganization and decoupling to make it easier to work with the codebase. The batch and KV cache abstractions and reimplementations will be done in follow-up PRs.TODO
move the(no)llama_mmaps
andllama_mlocks
fromllama_model
tollama_context
?_internal
suffix to_impl