Removes spurious \r in output that causes logging in journalctl to tr… #10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat lines as binary and therefore hidden by default Signed-off-by: Charles Darke <[email protected]>
|
@ggerganov Do you know why we have |
|
I'd rather llama.cpp break windows rather than breaking systemd logs on Linux. Here's how it looks in journalctl before this PR: |
|
Yeah in fact I'm ok with removing |
ggerganov
approved these changes
Dec 11, 2024
netrunnereve
pushed a commit
to netrunnereve/llama.cpp
that referenced
this pull request
Dec 16, 2024
…eat lines as binary and therefore hidden by default (ggerganov#10771) Signed-off-by: Charles Darke <[email protected]> Co-authored-by: Charles Darke <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
…eat lines as binary and therefore hidden by default (ggerganov#10771) Signed-off-by: Charles Darke <[email protected]> Co-authored-by: Charles Darke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eat lines as binary and therefore hidden by default
Make sure to read the contributing guidelines before submitting a PR