server : return stopping_word in the partial response #10720
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns the
stopping_word
field in the partial API response.The older versions of the server returned full info at the end of the partial response. The example for 6acce39 (Dec 1) that shows the last JSON line in streaming mode:
But with the new changes (6c5bc06), the server returns very little info.
The example for ecc93d0 (Dec 8):
IMHO this is a pretty drastic backwards-incompatible change. However, I'm not sure if that change is supposed to be this way or not, so this PR does not return the full info in the output, but only makes a minimal change to fix one small use-case: it returns the
stopping_word
field (the change in API broke my API client because it expects this field to be present).The API result with this PR applied:
However, I think that in the long run it's better to return all the info, like it was done before.