vulkan: compile a test shader in cmake to check for coopmat2 support #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
This was referenced Dec 8, 2024
0cc4m
approved these changes
Dec 8, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had assumed that Vulkan-Headers and shaderc would come from a matching Vulkan SDK (unless manually overridden), but it seems like some distros update them separately. That means we need a way to check whether glslc supports NV_cooperative_matrix2, and I don't know any other way than to do a test compile in cmake and parse the error output. Well, another option might be to use submodules and build shaderc, but that's a much bigger change.
This was reported at #10710 (comment) (but is not what the original bug is about).