Prevent web browser error and chat history not saving #10711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should already be fixed in the latest version, so this is not needed anymore. |
Sorry, I pulled from master yesterday and encountered this issue. You can see in my own branch that it's 1 commit ahead and (currently) 3 behind the remote branch, where the 3 commits aren't related to this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
When using bartowski/QwQ-32B-Preview-GGUF off huggingface, I would experience a console error about reading choices[0] at the end of the text generation. It would seem that chunk.data.choices doesn't exist at all!
This is adding an if statement to ensure that the member exists before appending to the chat's content.
Also removed chunk.data.stop as it was unused in the JS.