Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyservice: update protobuf to an recent release #1576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

keyservice: update protobuf to an recent release #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ generate: keyservice/keyservice.pb.go
$(GO) generate

%.pb.go: %.proto
protoc --go_out=plugins=grpc:. $<
protoc --go_grpc_opt=require_unimplemented_servers=false --go_grpc_out=. --go_out=. $<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this working with go_grpc, I have to use go-grpc:

Suggested change
protoc --go_grpc_opt=require_unimplemented_servers=false --go_grpc_out=. --go_out=. $<
protoc --go-grpc_opt=require_unimplemented_servers=false --go-grpc_out=. --go_out=. $<

I installed it with go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest (and go install google.golang.org/protobuf/cmd/protoc-gen-go@latest).

(With the latest version the generated files also look differently.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another stab at this then.


.PHONY: functional-tests
functional-tests:
Expand Down
126 changes: 4 additions & 122 deletions keyservice/keyservice.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions keyservice/keyservice.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
syntax = "proto3";

option go_package = "./keyservice";

message Key {
oneof key_type {
KmsKey kms_key = 1;
Expand Down
146 changes: 146 additions & 0 deletions keyservice/keyservice_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading