This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
fix handling of number fields in jira plugin #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes getsentry/sentry-jira#108 in this repo |
mattrobenolt
reviewed
Nov 3, 2016
| elif schema['type'] == 'number': | ||
| try: | ||
| v = int(v) | ||
| except ValueError: |
There was a problem hiding this comment.
This could also raise a TypeError if v were None or some other data structure entirely, so unless you're sure, I'd do except (TypeError, ValueError):
There was a problem hiding this comment.
there's a check above for if v:
| @@ -395,6 +395,11 @@ def create_issue(self, request, group, form_data, **kwargs): | |||
| v = [v] | |||
| elif schema.get('custom') == JIRA_CUSTOM_FIELD_TYPES.get('textarea'): | |||
| v = v | |||
| elif schema['type'] == 'number': | |||
| try: | |||
| v = int(v) | |||
There was a problem hiding this comment.
Just double check that this number value won't work with floats. If it does, this will truncate them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@getsentry/plugins