Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

feat(clubhouse): Add global search #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(clubhouse): Add global search #422

wants to merge 1 commit into from

Conversation

miketheman
Copy link
Contributor

Add a configuration for the user to opt-in for a Sentry project to search across all Clubhouse projects.
When the flag is active, skip adding the configured Clubhouse project ID to the search.

Resolves #344

Signed-off-by: Mike Fiedler [email protected]

Add a configuration for the user to opt-in for a Sentry project to
search across all Clubhouse projects.
When the flag is active, skip adding the configured Clubhouse project
ID to the search.

Resolves #344

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman
Copy link
Contributor Author

Example UI looks like this:

screen shot 2018-11-18 at 9 43 55 am

Not sure what's going on with the CSS and alignment - that's likely somewhere in sentry core?

@mkj28
Copy link

mkj28 commented Nov 19, 2018

Amazing, thanks @miketheman !

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the kind of thing that should have a test case.

@miketheman
Copy link
Contributor Author

@markstory Definitely makes sense to have one - I was having trouble finding any examples in the codebase that do configuration validation/mocking and then subsequently testing the resulting request.
Can you point me in the right direction?

@BYK BYK closed this Nov 20, 2019
@miketheman
Copy link
Contributor Author

So is the desire to no longer have this? Happy to disengage from contributing to the project if it's no longer desired.

@BYK BYK reopened this Nov 20, 2019
@BYK
Copy link
Member

BYK commented Nov 20, 2019

Hi @miketheman - closed the PR as this repo is going into archive mode soon and the PR had some merge conflicts. It needs to be ported over to getsentry/sentry anyway for us to merge. If you are still interested, would you mind porting this over to https://github.com/getsentry/sentry/tree/master/src/sentry_plugins/clubhouse ?

Sorry for the trouble! Also ping @markstory

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Clubhouse plugin to search globally or support multiple projects
4 participants