Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): Test moduleMetadataIntegration in CDN bundle integration tests #15053

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −13
Open

test(browser): Test moduleMetadataIntegration in CDN bundle integration tests #15053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3454a5a
test(browser): Test `moduleMetadataIntegration` in CDN bundle integra…
Lms24 Jan 17, 2025
bc16291
restore unrelated file
Lms24 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadata/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import * as Sentry from '@sentry/browser';

import { moduleMetadataIntegration } from '@sentry/browser';

Sentry.init({
dsn: 'https://[email protected]/1337',
integrations: [Sentry.moduleMetadataIntegration()],
integrations: [moduleMetadataIntegration()],
beforeSend(event) {
const moduleMetadataEntries = [];

Expand Down
5 changes: 0 additions & 5 deletions ...ages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadata/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';

sentryTest('should provide module_metadata on stack frames in beforeSend', async ({ getLocalTestUrl, page }) => {
// moduleMetadataIntegration is not included in any CDN bundles
if (process.env.PW_BUNDLE?.startsWith('bundle')) {
sentryTest.skip();
}

const url = await getLocalTestUrl({ testDir: __dirname });

const errorEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
Expand Down
7 changes: 5 additions & 2 deletions ...gration-tests/suites/integrations/moduleMetadata/appliesMetadataWithRewriteFrames/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import * as Sentry from '@sentry/browser';

import { moduleMetadataIntegration } from '@sentry/browser';
import { rewriteFramesIntegration } from '@sentry/browser';

Sentry.init({
dsn: 'https://[email protected]/1337',
integrations: [
Sentry.moduleMetadataIntegration(),
Sentry.rewriteFramesIntegration({
moduleMetadataIntegration(),
rewriteFramesIntegration({
iteratee: frame => {
return {
...frame,
Expand Down
5 changes: 0 additions & 5 deletions ...gration-tests/suites/integrations/moduleMetadata/appliesMetadataWithRewriteFrames/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
sentryTest(
'should provide module_metadata on stack frames in beforeSend even though an event processor (rewriteFramesIntegration) modified the filename',
async ({ getLocalTestUrl, page }) => {
// moduleMetadataIntegration is not included in any CDN bundles
if (process.env.PW_BUNDLE?.startsWith('bundle')) {
sentryTest.skip();
}

const url = await getLocalTestUrl({ testDir: __dirname });

const errorEvent = await getFirstSentryEnvelopeRequest<Event>(page, url);
Expand Down
Loading