Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sveltekit)!: Remove fetch proxy script injection and options #15012

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 14, 2025

draft as this depends on dropping SvelteKit 1.x support
closes #15007

Copy link

codecov bot commented Jan 14, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
20 2 18 0
View the top 2 failed tests by shortest run time
performance.test.ts captures a distributed navigation trace
Stack Traces | 2.18s run time
performance.test.ts:71:1 captures a distributed navigation trace
performance.test.ts performance eventscapture a distributed navigation trace
Stack Traces | 2.27s run time
performance.test.ts:55:3 capture a distributed navigation trace

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24 Lms24 self-assigned this Jan 14, 2025
@Lms24
Copy link
Member Author

Lms24 commented Jan 15, 2025

Okay so one unfortunate thing that the e2e tests surfaced: My initial fix in Sveltekit 1.26.0 missed one case where we'd load data with the stored away version of window.fetch instead of using the "current" one that our SDK patches. I opened sveltejs/kit#13315 but it means that if we move forward with this PR, we'll only fully support Sveltekit with the version from which my fix will hopefully be released with.

I think it's somewhat fine to make this tradeoff, if we document something like: The SDK supports SvelteKit 2.0.0 or greater but works best with SvelteKit 2.x.y or greater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SvelteKit fetch proxy script
1 participant