Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exclude enum-like constant blocks from comment rule #120

Merged
merged 3 commits into from
Nov 2, 2023
Merged

feat: Exclude enum-like constant blocks from comment rule #120

merged 3 commits into from
Nov 2, 2023

Conversation

deregtd
Copy link
Contributor

@deregtd deregtd commented Oct 30, 2023

See the large comment block inside doculint.go starting on line 275 for details

See the large comment block inside doculint.go starting on line 275 for details
@deregtd deregtd requested a review from a team as a code owner October 30, 2023 04:41
Copy link
Contributor

@george-e-shaw-iv george-e-shaw-iv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DT team approves (multiple members reviewed internally)

@jaredallard
Copy link
Contributor

Unfortunately, CircleCI doesn't let us conditionally (allow) a single commit to be tested... so tests will never run on this PR. I'll have to run them all locally then get this merged.

@jaredallard
Copy link
Contributor

Tests pass locally... merging.

@jaredallard jaredallard merged commit c26a6a0 into getoutreach:main Nov 2, 2023
1 check failed
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants