feat: allow CGO_ENABLED to be configurable for development #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DT-4070 · Allow CGO_ENABLED to be configured via service.yaml |
jaredallard
reviewed
Oct 18, 2023
jaredallard
reviewed
Oct 18, 2023
|
Link to code coverage report (posted by coverbot 🤖) |
3 tasks
jaredallard
approved these changes
Oct 18, 2023
|
🎉 This PR is included in version 2.21.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
We should not default to compile builds with CGo. This makes it difficult to build a service on a Linux host and run it in a container, particularly if the host and container have different glibc versions. Instead, use
service.yamlto configure whether CGo compilation is enabled, defaulting to false.Jira ID
DT-4070
Notes for your reviewers
A corresponding PR will need to be written for production builds, in
stencil-golang.