-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style of new range screenshots #1848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
range-widget-rating.png
seems to have not been updated. I've also noticed that you exported the whole template (there is a background) instead of exporting the phone layer. I've just created this pr #1849 and the attached screenshot shows that we can export the phone layer without that purple background.
Whoops, fixed, thank you.
Yes, that's the goal! You can see it in action at https://docs.getodk.org/collect-forms/ for example. The subtle container gives more weight to the images and matches slides and other assets that we now produce. I tried to make those steps clear in the readme, let me know if you think any updates are needed. |
Ahh, I see. But one more thing... your images have those white corners: |
This is a weird thing that happens sometimes because a layer might be turned off (I think the body layer might be hidden here). @lognaturel If you give me access to the file I can change it. |
Interesting, I thought it was an intentional update you made. I can’t give you edit access because of my account level but I can copy again from the main doc. I didn’t want to link to that one since it has so much in it! Or you can make a clean copy for us to use here if you prefer. |
The template that I made in my figma file is still the same, if you want to just copy that over? |
I was going too quickly and thought @grzesiek2010 was talking about the outer rounded corner rather than the weird extra white. I unfortunately can barely see that white because I use low contrast settings. I've fixed it by copying the original, thanks @alyblenkin. Is there a way to lock something down so that this doesn't happen? It has happened before and the only fix I found was to copy over again. I don't have any sense of what I'm doing to trigger it, sorry. Should be fixed now. |
Yes we can lock the layer! I just did it in my file, so you could copy that one or lock the same layer in your version. I'm not sure why it was changing. Layers can act up some times. |
@grzesiek2010 refreshed screenshots for
range
in #1846. This puts them in our docs template. It also adds a brief description of how to use the screenshot template to the README.