Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop nits #1276

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Desktop nits #1276

merged 6 commits into from
Jan 8, 2025

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Dec 26, 2024

This PR includes

  • Use mobile view in webview so the user does not have to scroll a lot.
  • Fix exception on data cap on desktop.
  • Add support for retry payment method if fails

@jigar-f jigar-f marked this pull request as ready for review January 3, 2025 06:29
@jigar-f jigar-f requested a review from atavism January 7, 2025 15:20
@jigar-f
Copy link
Contributor Author

jigar-f commented Jan 7, 2025

@atavism This is ready for review.

//We want to use mobile mode for webview on desktop
// Since we are showign app on mobile size it will be better to use mobile mode
// showing recommended mode user has to scroll a lot
preferredContentMode: UserPreferredContentMode.MOBILE),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@atavism atavism merged commit 47cb9a9 into main Jan 8, 2025
2 checks passed
@atavism atavism deleted the jigar/desktop-nits branch January 8, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants