Skip to content

Commit

Permalink
Merge pull request #305 from getlago/misc-remove-filters
Browse files Browse the repository at this point in the history
misc: Remove *_count fields
  • Loading branch information
rsempe authored Dec 11, 2024
2 parents bae0b27 + 067767d commit 2966766
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 132 deletions.
63 changes: 1 addition & 62 deletions openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/schemas/BillableMetric.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ required:
- billable_metric
properties:
billable_metric:
$ref: "./BillableMetricObjectExtended.yaml"
$ref: "./BillableMetricObject.yaml"
18 changes: 0 additions & 18 deletions src/schemas/BillableMetricObject.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ required:
- aggregation_type
- recurring
- created_at
- active_subscriptions_count
- draft_invoices_count
- plans_count
properties:
lago_id:
type: string
Expand Down Expand Up @@ -87,18 +84,3 @@ properties:
type: array
items:
$ref: "./BillableMetricFilterObject.yaml"
active_subscriptions_count:
type: integer
example: 4
description: "Number of active subscriptions using this billable metric."
deprecated: true
draft_invoices_count:
type: integer
example: 10
description: "Number of draft invoices for which this billable metric is listed as an invoice item."
deprecated: true
plans_count:
type: integer
example: 4
description: "Number of plans using this billable metric."
deprecated: true
16 changes: 0 additions & 16 deletions src/schemas/BillableMetricObjectExtended.yaml

This file was deleted.

10 changes: 0 additions & 10 deletions src/schemas/PlanObject.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ required:
- interval
- amount_cents
- amount_currency
- active_subscriptions_count
- draft_invoices_count
properties:
lago_id:
type: string
Expand Down Expand Up @@ -66,14 +64,6 @@ properties:
nullable: true
description: This field, when set to `true`, enables to invoice usage-based charges on monthly basis, even if the cadence of the plan is yearly. This allows customers to pay charges overage on a monthly basis. This can be set to true only if the plan's interval is `yearly`.
example: null
active_subscriptions_count:
type: integer
description: The count of active subscriptions that are currently associated with the plan. This field provides valuable information regarding the impact of deleting the plan. By checking the value of this field, you can determine the number of subscriptions that will be affected if the plan is deleted.
example: 0
draft_invoices_count:
type: integer
description: The number of draft invoices that include a subscription attached to the plan. This field provides valuable information about the impact of deleting the plan. By checking the value of this field, you can determine the number of draft invoices that will be affected if the plan is deleted.
example: 0
minimum_commitment:
$ref: "./MinimumCommitmentObject.yaml"
charges:
Expand Down
30 changes: 7 additions & 23 deletions src/schemas/TaxObject.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ required:
properties:
lago_id:
type: string
format: 'uuid'
format: "uuid"
description: Unique identifier of the tax, created by Lago.
example: '1a901a90-1a90-1a90-1a90-1a901a901a90'
example: "1a901a90-1a90-1a90-1a90-1a901a901a90"
name:
type: string
description: Name of the tax.
example: 'TVA'
example: "TVA"
code:
type: string
description: Unique code used to identify the tax associated with the API request.
example: 'french_standard_vat'
example: "french_standard_vat"
description:
type: string
description: Internal description of the taxe
example: 'French standard VAT'
example: "French standard VAT"
rate:
type: number
description: The percentage rate of the tax
Expand All @@ -33,24 +33,8 @@ properties:
type: boolean
description: Set to `true` if the tax is used as one of the organization's default
example: true
add_ons_count:
type: integer
description: Number of add-ons this tax is applied to.
example: 0
charges_count:
type: integer
description: Number of charges this tax is applied to.
example: 0
customers_count:
type: integer
description: Number of customers this tax is applied to (directly or via the organization's default).
example: 0
plans_count:
type: integer
description: Number of plans this tax is applied to.
example: 0
created_at:
type: string
format: 'date-time'
format: "date-time"
description: Creation date of the tax.
example: '2023-07-06T14:35:58Z'
example: "2023-07-06T14:35:58Z"
2 changes: 0 additions & 2 deletions src/schemas/_index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ BillableMetric:
$ref: "./BillableMetric.yaml"
BillableMetricObject:
$ref: "./BillableMetricObject.yaml"
BillableMetricObjectExtended:
$ref: "./BillableMetricObjectExtended.yaml"
BillableMetricBaseInput:
$ref: "./BillableMetricBaseInput.yaml"
BillableMetricCreateInput:
Expand Down

0 comments on commit 2966766

Please sign in to comment.