Feat(invoice_custom_sections): use custom sections in pdf #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-invoice-custom-sections-create-applied-service
branch
from
28e44be to
30325ba
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-pdf
branch
from
f1dfb75 to
7beee55
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-create-applied-service
branch
from
30325ba to
4ea553a
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-pdf
branch
from
6687849 to
93310f4
Compare
vincent-pochet
approved these changes
Jan 10, 2025
Comment on lines
+19
to
+23
| .joins('LEFT JOIN invoice_custom_section_selections ON invoice_custom_sections.id = invoice_custom_section_selections.invoice_custom_section_id | ||
| AND invoice_custom_section_selections.customer_id is NULL') | ||
| .order( | ||
| Arel.sql('CASE WHEN invoice_custom_section_selections.id IS NOT NULL THEN 0 ELSE 1 END'), | ||
| :name |
There was a problem hiding this comment.
No blocker here but maybe this should be turned into a scope. What do you think?
There was a problem hiding this comment.
I think it's not needed, because this sorting - by selected for organization, and then alphabetically - only needed in the graphql response... I can't see where else it will be useful... or do you mean it will be better for readability?
(in all other places we're usually using the selected sections and only sort them alphabetically)
annvelents
changed the title
annvelents
merged commit 2c5755f
into
feat-invoice-custom-sections-create-applied-service
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use applied invoice custom sections in PDFs and include them in invoice payload
Also includes fixes found after QA