Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (invoice_custom_sections): customer update service #2960

Merged
merged 29 commits into from
Jan 9, 2025

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Dec 13, 2024

Description

Added service to manage invoice_custom_sections on customer level

@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-resolvers branch from 9cfa90f to 06498bb Compare December 20, 2024 12:53
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-service branch from 2806aba to 4119b03 Compare December 20, 2024 13:37
Base automatically changed from feat-invoice-custom-sections-customer-resolvers to main December 23, 2024 10:15
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-service branch from 9ea2e42 to aa0a51e Compare December 23, 2024 10:20
@annvelents annvelents marked this pull request as ready for review December 26, 2024 10:15
@annvelents annvelents changed the title Feat:invoice_custom_sections - customer update service Feat (invoice_custom_sections): customer update service Dec 26, 2024
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments worth reviewing.

app/services/customers/update_service.rb Outdated Show resolved Hide resolved
app/services/customers/update_service.rb Outdated Show resolved Hide resolved
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-service branch from d39ca58 to 2e1e5f6 Compare December 30, 2024 12:48
@annvelents annvelents force-pushed the feat-invoice-custom-sections-customer-update-service branch from 2e1e5f6 to 20472d8 Compare December 30, 2024 15:42
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just a few comments

@annvelents annvelents merged commit 5437092 into main Jan 9, 2025
6 checks passed
@annvelents annvelents deleted the feat-invoice-custom-sections-customer-update-service branch January 9, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants