-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (invoice_custom_sections): customer update service #2960
Merged
annvelents
merged 29 commits into
main
from
feat-invoice-custom-sections-customer-update-service
Jan 9, 2025
Merged
Feat (invoice_custom_sections): customer update service #2960
annvelents
merged 29 commits into
main
from
feat-invoice-custom-sections-customer-update-service
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-resolvers
branch
from
December 20, 2024 12:53
9cfa90f
to
06498bb
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-service
branch
from
December 20, 2024 13:37
2806aba
to
4119b03
Compare
Base automatically changed from
feat-invoice-custom-sections-customer-resolvers
to
main
December 23, 2024 10:15
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-service
branch
from
December 23, 2024 10:20
9ea2e42
to
aa0a51e
Compare
annvelents
changed the title
Feat:invoice_custom_sections - customer update service
Feat (invoice_custom_sections): customer update service
Dec 26, 2024
ancorcruz
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few comments worth reviewing.
app/services/customers/update_invoice_custom_sections_service.rb
Outdated
Show resolved
Hide resolved
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-service
branch
from
December 30, 2024 12:48
d39ca58
to
2e1e5f6
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-service
branch
from
December 30, 2024 15:42
2e1e5f6
to
20472d8
Compare
ancorcruz
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just a few comments
app/services/customers/manage_invoice_custom_sections_service.rb
Outdated
Show resolved
Hide resolved
spec/services/customers/manage_invoice_custom_sections_service_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/customers/manage_invoice_custom_sections_service_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/organizations/deselect_invoice_custom_section_service_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/organizations/deselect_invoice_custom_section_service_spec.rb
Outdated
Show resolved
Hide resolved
annvelents
deleted the
feat-invoice-custom-sections-customer-update-service
branch
January 9, 2025 10:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added service to manage invoice_custom_sections on customer level