more fixes around tests

app/services/organizations/deselect_invoice_custom_section_service.rb

@@ -10,6 +10,7 @@ def initialize(section:)
 
     def call
       deselect_for_organization
+      result.section = section
       result
     end
 
@@ -23,7 +24,6 @@ def deselect_for_organization
       InvoiceCustomSectionSelection.where(
         organization_id: organization.id, invoice_custom_section_id: section.id
       ).destroy_all
-      result.section = section
     end
   end
 end

spec/services/customers/manage_invoice_custom_sections_service_spec.rb

@@ -86,7 +86,7 @@
 
         it "sets skip_invoice_custom_sections to false" do
           service.call
-          expect(customer.reload.skip_invoice_custom_sections).to be_false
+          expect(customer.reload.skip_invoice_custom_sections).to be false
           expect(customer.selected_invoice_custom_sections.ids).to match_array([])
           expect(customer.applicable_invoice_custom_sections.ids).to match_array(customer.organization.selected_invoice_custom_sections.ids)
         end
@@ -100,7 +100,7 @@
 
       it "sets skip_invoice_custom_sections to true" do
         service.call
-        expect(customer.reload.skip_invoice_custom_sections).to be_true
+        expect(customer.reload.skip_invoice_custom_sections).to be true
         expect(customer.selected_invoice_custom_sections).to be_empty
         expect(customer.applicable_invoice_custom_sections).to be_empty
       end

spec/services/organizations/deselect_invoice_custom_section_service_spec.rb

@@ -4,14 +4,16 @@
 
 RSpec.describe Organizations::DeselectInvoiceCustomSectionService, type: :service do
   describe '#call' do
-    subject(:service_result) { described_class.call(section:) }
+    subject(:service_call) { described_class.call(section:) }
 
     let(:organization) { create(:organization) }
     let(:section) { create(:invoice_custom_section, organization:) }
 
     context 'when section is not selected for the organization' do
       it 'deselects the section for the organization' do
-        expect(service_result).to be_success
+        result = service_call
+        expect(result).to be_success
+        expect(result.section.selected_for_organization?).to be false
       end
     end
 
@@ -21,9 +23,9 @@
       end
 
       it 'deselects the section for the organization' do
-        expect { service_result }.to change(organization.selected_invoice_custom_sections, :count).by(-1)
+        expect { service_call }.to change(organization.selected_invoice_custom_sections, :count).by(-1)
         expect(organization.invoice_custom_sections).to include(section)
-        expect(service_result).to be_success
+        expect(section.selected_for_organization?).to be false
       end
     end
   end