refactor: Set text input type to password if setting is secret (#153)

* set input type to password if setting is secret * set to password if setting is secret despite schema type
gethubai · May 20, 2024 · 9340507 · 9340507
1 parent 93ef81f
commit 9340507
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/renderer/components/form/form-widgets/hubaiTextWidget.tsx b/src/renderer/components/form/form-widgets/hubaiTextWidget.tsx
@@ -12,10 +12,19 @@ export default function HubaiTextWidget({
 }: WidgetProps) {
   let inputType = 'text'; // default to text input
 
-  if (schema.type === 'integer') {
-    inputType = 'number';
-  } else if (schema.type === 'number') {
-    inputType = 'text'; // Use text input to allow floating points, validate manually
+  if (schema.isSecret) {
+    inputType = 'password';
+  } else {
+    switch (schema.type) {
+      case 'integer':
+        inputType = 'number';
+        break;
+      case 'number':
+        inputType = 'text'; // Use text input to allow floating points, validate manually
+        break;
+      default:
+        break;
+    }
   }
 
   const handleChange = useCallback(

diff --git a/src/renderer/components/form/settingsMapForm.tsx b/src/renderer/components/form/settingsMapForm.tsx
@@ -59,6 +59,8 @@ export function MapSettingToSchema(setting: ISettingMap): RJSFSchema {
     defaultValueParsed = defaultValue === 'true';
   }
 
+  const isSecret = !!setting.isSecret;
+
   function getEnumValues(): string[] | undefined {
     if (typeof enumValues === 'function') {
       return enumValues?.();
@@ -74,6 +76,7 @@ export function MapSettingToSchema(setting: ISettingMap): RJSFSchema {
     enum: getEnumValues(),
     description,
     originalName: name,
+    isSecret,
   };
 
   return property;