Skip to content

feat: add diff normalization logic util #1830

feat: add diff normalization logic util

feat: add diff normalization logic util #1830

GitHub Actions / clippy failed Nov 17, 2024 in 0s

clippy

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check failure on line 108 in crates/util/src/diff_standardizer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> crates/util/src/diff_standardizer.rs:108:49
    |
108 |                     standardized_after.push_str(&content);
    |                                                 ^^^^^^^^ help: change this to: `content`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 105 in crates/util/src/diff_standardizer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
   --> crates/util/src/diff_standardizer.rs:105:17
    |
105 |             let mut current_line = before_line_num;
    |                 ----^^^^^^^^^^^^
    |                 |
    |                 help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_mut)]`

Check failure on line 8 in crates/util/src/diff_standardizer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Delta`

error: unused import: `Delta`
 --> crates/util/src/diff_standardizer.rs:8:12
  |
8 | use git2::{Delta, DiffLineType, DiffOptions, Repository};
  |            ^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 1 in crates/util/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

external crate `tempfile` unused in `marzano_util`: remove the dependency or add `use tempfile as _;`

error: external crate `tempfile` unused in `marzano_util`: remove the dependency or add `use tempfile as _;`
  |
  = note: `-D unused-crate-dependencies` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_crate_dependencies)]`