Fix Arabic Selection Option #1236
Conversation
| @@ -4,8 +4,10 @@ | |||
| "repository": "https://github.com/getfider/fider", | |||
| "private": true, | |||
| "dependencies": { | |||
| "@lingui/core": "^3.13.3", | |||
There was a problem hiding this comment.
Why did you need to change these dependencies here?
There was a problem hiding this comment.
I'm not developer, so I used Cursor to fix Arabic issue
| @@ -1,4 +1,4 @@ | |||
| $font-base: 'Inter', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", "Helvetica Neue", Arial, "Noto Sans", sans-serif, | |||
| $font-base: 'IBM Plex Sans Arabic', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", "Helvetica Neue", Arial, "Noto Sans", sans-serif, | |||
There was a problem hiding this comment.
We can't change the font, this change would make that font the default for all. We need to work out a solution that will choose Inter for all non-arabic systems, and use your font for all users who those the arabic language?
There was a problem hiding this comment.
Agree with you, maybe some condition
| @@ -3,6 +3,7 @@ | |||
| "action.change": "تغيير", | |||
| "action.close": "إغلاق", | |||
| "action.confirm": "تأكيد", | |||
| "action.copylink": "نسخ الرابط", | |||
There was a problem hiding this comment.
Sorry, we don't manage changes to the localised strings here.
Please can you make the changes to the arabic strings here: https://crowdin.com/project/fider
Then they can be pulled into the next release
Thanks
There was a problem hiding this comment.
Sure I will upload an updated version, but I still have some modification on it along with some missing strings
| @@ -0,0 +1,142 @@ | |||
| package letteravatar | |||
There was a problem hiding this comment.
This looks interesting. So you use the font to generate the letter avatar, so that it supports arabic letters. That's cool - if we used this we'd just need to make sure we can support both arabic and non-arabic. Do you have any thoughts about how best to manage that?
There was a problem hiding this comment.
I give up and convert the Arabic letters to English,Ex: ب = B , from my very basic experience with php and converting text to image, Arabic language is very challenging
There was a problem hiding this comment.
Hi @BasselArt
Thanks for the PR and the work you're doing to make Fider work in arabic.
I'm not sure however what i can do with this. From a quick scan through the code I see that many of the changes you have added break the existing app for other languages in order to make it work for Arabic. Obviously the only way that we could consider getting these pulled in would be if the changes were fully compatible with all languages.
Thanks
Matt
Issue: