Skip to content

Commit

Permalink
More notification spacing tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
mattwoberts committed Oct 7, 2024
1 parent eedd58e commit 941fdb4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
6 changes: 2 additions & 4 deletions public/assets/styles/utility/display.scss
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
border: 0 solid get("colors.gray.100");
border-top-width: 1px;
}
.flex-y.flex--divide-#{$i}:not(.no-lastchild-paddingzero) > *:last-child {
.flex-y.flex--divide-#{$i} > *:last-child {
padding-bottom: 0;
}
}
Expand Down Expand Up @@ -204,10 +204,8 @@
pointer-events: inherit;
}


.hover {
&:hover {
background-color: get("colors.gray.100")
background-color: get("colors.gray.100");
}
}

3 changes: 3 additions & 0 deletions public/components/NotificationIndicator.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@
.c-notifications-container {
max-height: 80vh;
overflow-y: auto;
@include media("lg") {
min-width: 400px;
}
}
6 changes: 3 additions & 3 deletions public/components/NotificationIndicator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const NotificationItem = ({ notification }: { notification: Notification
}

return (
<HStack spacing={4} className="px-3 pr-5 clickable hover py-2" onClick={openNotification}>
<HStack spacing={4} className="px-3 pr-5 clickable hover py-4" onClick={openNotification}>
<Avatar user={{ name: notification.authorName, avatarURL: notification.avatarURL }} />
<div>
<Markdown className="c-notification-indicator-text" text={notification.title} style="full" />
Expand Down Expand Up @@ -93,7 +93,7 @@ export const NotificationIndicator = () => {
<p className="text-subtitle px-4 mt-2 mb-0">
<Trans id="modal.notifications.unread">Unread notifications</Trans>
</p>
<VStack spacing={2} className="py-3 mb-2 no-lastchild-paddingzero" divide={true}>
<VStack spacing={0} className="my-2" divide={false}>
{unread.map((n) => (
<NotificationItem key={n.id} notification={n} />
))}
Expand All @@ -112,7 +112,7 @@ export const NotificationIndicator = () => {
<p className="text-subtitle px-4 mb-0">
<Trans id="modal.notifications.previous">Previous notifications</Trans>
</p>
<VStack spacing={2} className="py-2 no-lastchild-paddingzero" divide={true}>
<VStack spacing={0} className="my-2" divide={false}>
{recent.map((n) => (
<NotificationItem key={n.id} notification={n} />
))}
Expand Down

0 comments on commit 941fdb4

Please sign in to comment.