Added a return to the previous step Button inside the seller setup wizard and adjusted RTL layout issue #2309
Conversation
…step Button layout inside the seller setup wizard. Added necessary CSS to adjust the newly added Return to the previous step Button layout inside the seller setup wizard to make the button three columns.
WalkthroughThe changes introduce a new CSS rule in Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- assets/css/setup.css (1 hunks)
- includes/Vendor/SetupWizard.php (8 hunks)
Files skipped from review due to trivial changes (1)
- assets/css/setup.css
Additional comments not posted (10)
includes/Vendor/SetupWizard.php (10)
12-12: Ensure proper documentation for the$stepproperty.The
$stepproperty is documented as a string representing the current step. Ensure that the documentation is consistent with its usage.
20-20: Ensure proper documentation for the$custom_logoproperty.The
$custom_logoproperty is documented as a string representing the custom logo URL. Ensure that the documentation is consistent with its usage.
21-21: Ensure proper documentation for the$store_idproperty.The
$store_idproperty is documented as an integer. Ensure that the documentation is consistent with its usage.
24-24: Ensure proper documentation for the$store_infoproperty.The
$store_infoproperty is documented as an array. Ensure that the documentation is consistent with its usage.
36-36: Verify the initialization of new properties in thesetup_wizardmethod.The
setup_wizardmethod initializes the new properties. Ensure that the initialization is correct and consistent with the class's requirements.
366-366: Verify the addition of the return button in thedokan_setup_storemethod.The
dokan_setup_storemethod includes a return button to the previous step. Ensure that the button is correctly implemented and functional.
573-573: Verify the addition of the return button in thedokan_setup_paymentmethod.The
dokan_setup_paymentmethod includes a return button to the previous step. Ensure that the button is correctly implemented and functional.
662-662: Verify the addition of the return button in thedokan_setup_readymethod.The
dokan_setup_readymethod includes a return button to the previous step. Ensure that the button is correctly implemented and functional.
669-679: Ensure proper implementation of theget_previous_step_linkmethod.The
get_previous_step_linkmethod generates the link to the previous step. Ensure that the method is correctly implemented and handles errors appropriately.
Line range hint
505-523:
Verify the validation logic in thedokan_setup_store_savemethod.The
dokan_setup_store_savemethod includes validation for the new fields. Ensure that the validation logic is correctly implemented and handles errors appropriately.
TanvirHasan19
changed the title
TanvirHasan19
added
Needs: Testing
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
assets/css/setup.css (1)
259-261: Consider alternatives to using !importantThe
!importantdeclaration should be avoided as it:
- Makes styles harder to override when needed
- Creates specificity wars
- Reduces maintainability
Consider these alternatives:
-.dokan-vendor-setup-wizard form .wc-setup-actions .button{ - padding: 11px!important; -} +/* Option 1: Increase specificity */ +.dokan-vendor-setup-wizard form .wc-setup-actions .button.button { + padding: 11px; +} + +/* Option 2: Use more specific selectors */ +.dokan-vendor-setup-wizard form .wc-setup-actions .button[type="submit"], +.dokan-vendor-setup-wizard form .wc-setup-actions .button[type="button"] { + padding: 11px; +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
assets/css/setup.css(1 hunks)
🔇 Additional comments (2)
assets/css/setup.css (2)
Line range hint 1-261: Missing RTL support mentioned in PR objectives
The PR objectives mention fixing RTL layout issues, but there are no RTL-specific styles added. Consider adding RTL support using one of these approaches:
- Using CSS logical properties:
/* Instead of left/right, use logical properties */
.wc-wizard-service-item .wc-wizard-service-name {
padding-inline-start: 20px;
}- Using the
dirattribute:
/* Add RTL-specific rules */
[dir="rtl"] .wc-wizard-service-item .wc-wizard-service-name {
padding-right: 20px;
padding-left: 0;
}Let's verify the RTL-related changes:
Line range hint 1-261: Verify RTL changes in other files
The PR objectives mention RTL layout fixes, but the changes in this CSS file don't fully address RTL support. Let's verify if RTL-related changes exist in other files:
✅ Verification successful
RTL support is properly handled in the codebase
Based on the search results, RTL support is well implemented across the codebase:
- Dedicated RTL CSS files exist:
assets/css/rtl.css- Main RTL stylesheet- Multiple component-specific RTL stylesheets under assets/js/
- RTL detection and handling:
is_rtl()checks are used to conditionally apply RTL styles- RTL-specific selectors and rules in CSS files
- RTL attributes in HTML templates
- RTL-aware components:
- Select2 dropdown has RTL support
- Vue components handle RTL layout
- Charts and graphs respect RTL direction
The changes in setup.css appear to be general styling updates and don't require additional RTL-specific changes since RTL support is already handled through the dedicated RTL stylesheets.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Look for RTL-related changes in other files
# Search for RTL-related files
echo "Checking for RTL-specific files..."
fd -e css rtl
# Search for RTL-related changes in all files
echo "Checking for RTL-related code..."
rg -i 'rtl|direction|right-to-left|left-to-right'
# Search for style-rtl.css generation in build scripts
echo "Checking build scripts for RTL handling..."
fd -e json -e js 'webpack|gulp|grunt'
Length of output: 107854
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
https://prnt.sc/LGIbars_Gr1I
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit