Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit funds transferred from shared wallet to hub node #794

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: limit funds transferred from shared wallet to hub node #794

merged 1 commit into from
Nov 13, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 13, 2024

Fixes #781

  • renamed "migrate" to "transfer" to match getalby.com/node page
  • when transferring funds on first channel open, will not repeatedly drain funds (except when user only has small amount of funds left over)
  • transfer funds endpoint now caps the amount to transfer to 1M sats.

@rolznz rolznz requested a review from bumi November 13, 2024 06:42
@bumi
Copy link
Contributor

bumi commented Nov 13, 2024

lgtm! great

@rolznz rolznz merged commit 55f8f10 into master Nov 13, 2024
9 checks passed
@rolznz rolznz deleted the fix/transfer-funds-limit branch November 13, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi Awaiting requested review from bumi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict migration of funds from shared wallet to node to 1M sats per transaction
2 participants
@rolznz @bumi