feat: notification improvements #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Nov 12, 2024
| @@ -0,0 +1,117 @@ | |||
| #import "NotificationService.h" | |||
There was a problem hiding this comment.
is this only for iOS? should it be in a dedicated directory?
rolznz
reviewed
Nov 12, 2024
| return; | ||
| } | ||
|
|
||
| NSString *sharedSecretString = walletInfo[@"sharedSecret"]; |
There was a problem hiding this comment.
could the name be more clear, maybe nip04SharedSecret? or dmSharedSecret? and does this change much if we plan to very soon move to NIP-44?
rolznz
reviewed
Nov 12, 2024
| } catch (error) { | ||
| errorToast(error); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
rather than a huge if content with an else right at the bottom, could you do the check at the top and exit the function early?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Replace
NOSTR_API_URLto local http-nostr urlRun feat: add endpoint for registering alby go notifications http-nostr#128 and use
ngrok http 8888Copy the ngrok link to NOSTR_API_URL in constants
If running on android, download
google-services.jsonfrom firebase console and add it to the root of your directory and set this in your .env.local:GOOGLE_SERVICES_JSON=./google-services.jsonConnect your device via cable and run yarn install and then
npx expo run:ios --device/npx expo run:android --deviceEnable notifications in settings and receive a transaction to get notified (tapping on the notification also switches to the right wallet and takes you to the transaction screen)