Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ introduce account v2 draft code #93

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Apr 18, 2024

This draft boilerplate introduces the upgrade function that reinitializes the contract and burns the nonce 0. The burn of the nonce 0 is required if the entrypoint changes. There are no consequences for burning arbitrary nonce value

@qd-qd qd-qd self-assigned this Apr 18, 2024
This draft boilerplate introduces the upgrade function that reinitializes
the contract and burns the nonce 0. The burn of the nonce 0 is required
if the entrypoint changes. There are no consequences for burning arbitrary
nonce value
@qd-qd qd-qd force-pushed the feat/account-v2-boilerplate branch from fa17c92 to 00f3381 Compare April 18, 2024 15:48
Base automatically changed from refactoring/create-signature-flow to main April 18, 2024 15:50
Copy link

github-actions bot commented Apr 18, 2024

Changes to gas cost

Generated at commit: e0f02bd74714fcb8d73a4adbe4db7bf768a7a48b, compared to commit: d55272ec6596662595f79b927103d08d4001bffc

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Paymaster 1,187,147 (0) postOp 22,227 (0) 0.00% 22,842 (+1) +0.00% 22,425 (0) 0.00% 24,075 (0) 0.00% 512 (0)
SignerVaultWebAuthnP256R1Harness 799,066 (0) exposed_remove 29,743 (0) 0.00% 29,931 (+1) +0.00% 30,040 (0) 0.00% 30,040 (0) 0.00% 256 (0)
ERC1967Proxy 0 (0) exposed_validateCreationSignature 33,744 (0) 0.00% 49,560 (-1) -0.00% 51,661 (0) 0.00% 59,026 (0) 0.00% 1,795 (0)
AccountFactory 1,118,387 (0) createAndInitAccount 36,307 (0) 0.00% 67,030 (+1) +0.00% 39,240 (0) 0.00% 251,304 (0) 0.00% 296 (0)

@qd-qd qd-qd merged commit 00f3381 into main Apr 18, 2024
3 checks passed
@qd-qd qd-qd deleted the feat/account-v2-boilerplate branch April 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant