Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍱 ecdsa256r1: fully-test wycheproof #46

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Nov 7, 2023

Add all the wycheproof vectors missing and update the test files to make the test suites performant.

@qd-qd qd-qd self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Changes to gas cost

Generated at commit: 3c12c6c21782599aa473a9d24789b45f1928c985, compared to commit: 616ce6d53e6274cd8641488f34212ff885639b3b

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ImplementationECDSA256r1 verify -143 ✅ -0.07%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ImplementationECDSA256r1 1,010,247 (0) verify 168,723 (-23,897) -12.41% 202,816 (-143) -0.07% 203,380 (+475) +0.23% 230,757 (+20,678) +9.84% 566 (+509)

Copy link

github-actions bot commented Nov 7, 2023

LCOV of commit 807c72b during Tests #202

Summary coverage rate:
  lines......: 88.3% (68 of 77 lines)
  functions..: 100.0% (7 of 7 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/ECDSA256r1.sol | 100%     35| 100%     2|    -      0

@qd-qd qd-qd force-pushed the test/improve-wycheproof branch from 14d4718 to 241a5b4 Compare November 7, 2023 10:24
Add all the wycheproof vectors missing and update the test files to
make the test suites performant.
@qd-qd qd-qd force-pushed the test/improve-wycheproof branch from 241a5b4 to 807c72b Compare November 7, 2023 10:28
@qd-qd qd-qd merged commit 807c72b into main Nov 7, 2023
7 checks passed
@qd-qd qd-qd deleted the test/improve-wycheproof branch November 7, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant