Skip to content

Commit

Permalink
Reduce module cache size (#33057)
Browse files Browse the repository at this point in the history
This PR reduces the max module cache size from 250MB to 100MB, which is the max push size. We could make this lower if we stop fetching all modules on cache miss, but if we set it lower now, it will make the cache useless for larger codebases.

GitOrigin-RevId: 5e752b4771358b518cbf65707a8be061e15a09dc
  • Loading branch information
emmaling27 authored and Convex, Inc. committed Jan 10, 2025
1 parent 23f71a9 commit e319dfb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/common/src/knobs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ pub static ARCHIVE_FETCH_TIMEOUT_SECONDS: LazyLock<Duration> =
/// The total number of modules across all versions that will be held in memory
/// at once.
pub static MODULE_CACHE_MAX_SIZE_BYTES: LazyLock<u64> =
LazyLock::new(|| env_config("MODULE_CACHE_MAX_SIZE_BYTES", 250_000_000));
LazyLock::new(|| env_config("MODULE_CACHE_MAX_SIZE_BYTES", 100_000_000));

/// The maximum number of concurrent module fetches we'll allow.
pub static MODULE_CACHE_MAX_CONCURRENCY: LazyLock<usize> =
Expand Down

0 comments on commit e319dfb

Please sign in to comment.