Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.2 #20

Merged
merged 6 commits into from
May 12, 2024
Merged

Prepare v0.2 #20

merged 6 commits into from
May 12, 2024

Conversation

b4l
Copy link
Member

@b4l b4l commented Apr 14, 2024

In preparation for #19, I would like to do a v0.2 release for all crates in the workspace.

@b4l b4l requested a review from pka April 14, 2024 09:28
@b4l b4l mentioned this pull request Apr 14, 2024
Copy link
Member

@pka pka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, totally missed this review request. I've successfully tested ogcapi-types, thanks!

@@ -13,4 +14,4 @@ default-members = ["ogcapi"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/georust/ogcapi"
edition = "2021"
rust-version = "1.66"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Rust 1.75 required? I've got requests from users that crates should be compilable with the Rust version of Debian Stable, which is 1.63...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the rust version altogether and let the users find out what is working by themself. Anyways, it is not a verified lower bound since we only test the latest Rust version in the CI. If we want to ensure compatibility with Debian stable, we probably should add that to the CI (maybe just for ogcapi-types? though it's somewhat odd to use the Debian system toolchain).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with omitting rust-version. Optimally, the minimal version required is determined by checking the rustc changelog or with a tool like https://github.com/foresterre/cargo-msrv

The latter is quite time consuming, since it builds the code with different toolchain versions. For me, the Debian toolchain is not an important requirement, just a reminder to be conservative using brand new compiler features.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat biased on this as I think we should not try to accomodate some subjective level of conservativity. My policy was always what is in current stable is fine. If users wants to be conservative they have to take care of it themselves and maybe wait out on new releases until it works for their environment. Then again, this is just me pushing away responsibility and keep my life as simple as possible ;)

@b4l b4l merged commit afecd9c into main May 12, 2024
1 check passed
@b4l b4l deleted the v0.2 branch May 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants