Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 7.1+ #39

Merged
merged 8 commits into from
May 17, 2024
Merged

Support Rails 7.1+ #39

merged 8 commits into from
May 17, 2024

Conversation

ewlarson
Copy link
Member

@ewlarson ewlarson commented May 14, 2024 •
edited
Loading

  • Gems: Bump Rails to support v7.1 and stop at < v8.0.
  • CI: Resolve GitHub CI errors
  • Views: Call resize_to_fit instead of resize

Fixes #40

@ewlarson
Bump Rails and CI matrix
afe6630 
Bump Rails
@ewlarson
StandardRB fixes
aeb7a7a
@ewlarson
CI fixes
9656a34 
* remove rails_helper.rb for spec_helper.rb
* bump test gems
* standardrb fixes
@ewlarson ewlarson changed the title Bump Rails and CI matrix Support Rails 7.1+ May 14, 2024
@ewlarson ewlarson marked this pull request as ready for review May 14, 2024 19:53
@ewlarson ewlarson marked this pull request as draft May 14, 2024 19:58
@ewlarson
Update _index_split_default.html.erb
51c0c9a 
Use resize_to_fit for variants
@ewlarson ewlarson marked this pull request as ready for review May 14, 2024 21:02
@eliotjordan eliotjordan merged commit 1a8b554 into develop May 17, 2024
3 checks passed
@eliotjordan eliotjordan deleted the feature/rails-7.1 branch May 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliotjordan eliotjordan eliotjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rails 7.1 support
2 participants
@ewlarson @eliotjordan