Do not export PMS variables in EAPI 9 #1407

Flowdalic · 2024-12-30T14:08:21Z

Instead of passing PMS variables as part of the process environment, we pass them via a file that is later sourced by the ebuild's bash.

Since, for example, A is usually the greatest contributor to the process environment, removing it from the process environment significantly avoids running into MAX_ARG_STRLEN when spawning a new child process.

This means that A and other PMS variables are no longer exported in the ebuild and hence unavaiable to child processes. However, A is mostly used as part of the default_src_unpack function and there A does not need to be exported.

This started as a change that only unexported A, but was later extended to most PMS variables as suggested by ulm in https://bugs.gentoo.org/721088#c23.

Thanks to Zac Medico for helpful input on this change.

Closes: https://bugs.gentoo.org/721088

lib/portage/const.py

lib/portage/package/ebuild/doebuild.py

Once a future EAPI does no longer export PMS variables (bug #721088 and [1]), we need to explicitly ensure that those are exported to helper commands which expect certain PMS variables in their process environment. While the portage ebuild is usually deliberately not using the latest EAPI, it may be a good idea to make it explicit that the _compat_upgrade helpers expect ED in their process environment. 1: gentoo/portage#1407 Signed-off-by: Florian Schmaus <[email protected]>

Once a future EAPI does no longer export PMS variables (bug #721088 and [1]), we need to explicitly ensure that those are exported to helper commands which expect certain PMS variables in their process environment. While the portage ebuild is usually deliberately not using the latest EAPI, it may be a good idea to make it explicit that the _compat_upgrade helpers expect ED in their process environment. 1: gentoo/portage#1407 Signed-off-by: Florian Schmaus <[email protected]> Closes: #39934 Signed-off-by: Sam James <[email protected]>

lib/portage/package/ebuild/doebuild.py

bin/isolated-functions.sh

Flowdalic · 2025-01-10T08:12:59Z

Now is a good time for others to test this patch and the feature. Set FEATURES="${FEATURES} -export-pms-vars" in make.conf to enable the behavior in all existing EAPIs. Make sure to use sys-apps/portage-9999, since sys-apps/portage was the only ebuild I have encountered so far that is affected by this change, and the -9999 ebuild of portage takes it into consideration.

lib/portage/package/ebuild/doebuild.py

bin/phase-functions.sh

Instead of passing PMS variables as part of the process environment, we pass them via a file that is later sourced by the ebuild's bash. Since, for example, A is usually the greatest contributor to the process environment, removing it from the process environment significantly avoids running into MAX_ARG_STRLEN when spawning a new child process. This means that A and other PMS variables are no longer exported in the ebuild and hence unavaiable to child processes. However, A is mostly used as part of the default_src_unpack function and there A does not need to be exported. This started as a change that only unexported A, but was later extended to most PMS variables as suggested by ulm in https://bugs.gentoo.org/721088#c23. Thanks to Zac Medico for helpful input on this change, and to Eli Schwartz for suggesting that (bash) helpers should simply source the environment file introduced by this change. Closes: https://bugs.gentoo.org/721088 Signed-off-by: Florian Schmaus <[email protected]>

Flowdalic force-pushed the pass-env-via-file-dont-export-pms-vars branch from 13610de to 6753aea Compare December 30, 2024 15:44

Flowdalic changed the title ~~WIP: Do not export PMS variables in EAPI 9~~ Do not export PMS variables in EAPI 9 Dec 30, 2024

Flowdalic force-pushed the pass-env-via-file-dont-export-pms-vars branch 5 times, most recently from 879a6fb to 67106ed Compare December 30, 2024 18:40

zmedico reviewed Dec 30, 2024

View reviewed changes

lib/portage/const.py Outdated Show resolved Hide resolved

Flowdalic force-pushed the pass-env-via-file-dont-export-pms-vars branch 2 times, most recently from 4ba182a to a8e44e3 Compare December 31, 2024 09:20

Flowdalic commented Dec 31, 2024

View reviewed changes