chore: refactor(move) browser-installer utils #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Dec 25, 2024
| type DownloadProgressCallback, | ||
| } from "../utils"; | ||
| import registry from "../registry"; | ||
| import { normalizeChromeVersion } from "../utils"; | ||
| import { installUbuntuPackageDependencies } from "../ubuntu-packages"; | ||
| import { installChromeDriver } from "./driver"; | ||
| import { BrowserName } from "../../browser/types"; |
There was a problem hiding this comment.
Browser from "../utils" -> BrowserName from "../../browser/types"
| @@ -5,21 +5,25 @@ import { | |||
| getBrowserPlatform, | |||
| getChromeDriverDir, | |||
| getMilestone, | |||
| Driver, | |||
| DriverName, | |||
There was a problem hiding this comment.
Driver -> DriverName
| export type SupportedBrowser = (typeof Browser)[keyof typeof Browser]; | ||
| export type SupportedDriver = (typeof Driver)[keyof typeof Driver]; | ||
|
|
||
| export const getNormalizedBrowserName = ( |
There was a problem hiding this comment.
Moved to "src/browser/utils"
| import { MIN_CHROME_VERSION_SUPPORT_ISOLATION } from "../constants/browser"; | ||
|
|
||
| export const isSupportIsolation = (browserName: string, browserVersion = ""): boolean => { | ||
| const browserVersionMajor = browserVersion.split(".")[0]; | ||
|
|
||
| return browserName === "chrome" && Number(browserVersionMajor) >= MIN_CHROME_VERSION_SUPPORT_ISOLATION; | ||
| }; | ||
|
|
||
| export const getNormalizedBrowserName = (browserName?: string): W3CBrowserName | null => { |
There was a problem hiding this comment.
Moved from "src/browser-installer/utils"
There was a problem hiding this comment.
Renamed from ".js"
| EDGE: "MicrosoftEdge", | ||
| } as const; | ||
|
|
||
| export type W3CBrowserName = Exclude<(typeof BrowserName)[keyof typeof BrowserName], PuppeteerBrowser.CHROMIUM>; |
There was a problem hiding this comment.
"chromium", unlike others, is not a valid W3C browser name
KuznetsovRoman
commented
Dec 25, 2024
sipayRT
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change Testplane behaviour