Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook-example): add example with storybook screenshot tests #1013

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

sipayRT
Copy link
Member

@sipayRT sipayRT commented Sep 12, 2024

No description provided.

Copy link
Member

@KuznetsovRoman KuznetsovRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if examples were in typescript.
We could also show examples of using manual tests with typescript:
https://github.com/gemini-testing/testplane-storybook?tab=readme-ov-file#advanced-usage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave this example and indicated in the README that this is an example of a regular test

Comment on lines 28 to 29
"testplane": "^8.20.1",
"ts-node": "^10.9.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add "@swc/core"

@sipayRT sipayRT force-pushed the sp.storybook-example branch from 2e6aaa7 to 8c6f100 Compare September 13, 2024 09:19
@sipayRT sipayRT merged commit aafcf23 into master Sep 13, 2024
2 checks passed
@sipayRT sipayRT deleted the sp.storybook-example branch September 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants