Bottom section of about us #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for geeksblabla pending review.Visit the deploys page to approve it
|
yjose
reviewed
Oct 19, 2024
yjose
approved these changes
Oct 19, 2024
|
To prevent issues with typing and json file and add validation i would suggest using a loader to load data from json file instead of a simple import, you can check content/config.ts and do the same as we do with image gallery mock data |
|
For text color and font size make sure to use custom config, check tailwind.config.js |
Getting the accurate colors from the Figma design
yjose
requested changes
Oct 20, 2024
yjose
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.